Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

avoid invalid account error on create vesting account #1112

Merged
merged 4 commits into from
Jun 6, 2022
Merged

avoid invalid account error on create vesting account #1112

merged 4 commits into from
Jun 6, 2022

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jun 5, 2022

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, pending changelog entry

types/account.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 5, 2022 •
edited
Loading

Codecov Report

Merging #1112 (246edb9) into main (620f6a6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
- Coverage   61.78%   61.77%   -0.02%     
==========================================
  Files          88       88              
  Lines        7257     7259       +2     
==========================================
  Hits         4484     4484              
- Misses       2553     2555       +2     
  Partials      220      220
Impacted Files Coverage Δ
types/account.go 26.31% <0.00%> (-3.10%) ⬇️

alexanderbez
alexanderbez approved these changes Jun 5, 2022
View reviewed changes
types/account.go Show resolved Hide resolved
fedekunze
fedekunze suggested changes Jun 5, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit 707b49d into evmos:main Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crypto-facs crypto-facs crypto-facs approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmsqe @alexanderbez @fedekunze @crypto-facs